Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tagging): query tagging and send session param #1627

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Sep 30, 2024

Pull request template

queryTaggingDebounceMs was always being initialized to undefined and that's why query tagging was not working properly when there were semantics. Also, session param was not being sent in the tagging because the consent was always set as null.

The solution to these problems is to set a default value for these variables in the tagging.vue component.

Next steps:

  • Update x-components in archetype
  • Update x-components in my-motive-marketplace
  • Update x-components in bigbuy
  • Update x-components in primor
  • Check if there are more repos with this bug

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Check if query tagging and consent work in a customer (f.e. archetype).

@lauramargar lauramargar requested a review from a team as a code owner September 30, 2024 08:31
@lauramargar lauramargar merged commit 69dd690 into main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants