-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve Fish shell support (and Cshell) #1429
Conversation
I am not sure why the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. One last nit and we can submit I think
Looks like flake8 also found a couple of nits |
d022c94
to
0665321
Compare
Yes, sorry about that I don't have a proper python setup locally I have to check ci output everytime. |
logs in https://circleci.com/api/v1.1/project/github/emscripten-core/emsdk/14456/output/106/0?file=true&allocation-id=66aabe4cea13c3196692b681-0-build%2FABCDEFGH, indicate ...
[ 14%] Building CXX object src/wasm/CMakeFiles/wasm.dir/parsing.cpp.o
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make[2]: *** [src/parser/CMakeFiles/parser.dir/build.make:128: src/parser/CMakeFiles/parser.dir/parse-3-implicit-types.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs
... I am guessing it's a resource issue, the step |
Turns out this is what was causing the OOM when building binaryen since we were clobbering the EMSDK_NUM_CORES environment variable by mistake.
Oops, looks like there was a missing comma: #1433 |
I faced the same issue mentioned in #1299, this PR fixes the issue by taking in account specific
set
andunset
syntax for Fish shell.The post install instruction (i.e :
./emsdk activate latest
) provides wrong instructions in Fish shell and Cshell cases.This should be fixed by this PR too, although the code is a bit redundant and it could be more cleaner.
The website instruction have the same issue, but I guess user with specific shell will be able to manage.