refactor: removed useCallback

Relates #256
enBloc-org · Jun 27, 2024 · 1e1b8bb · 1e1b8bb
1 parent c15ce5e
commit 1e1b8bb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 20 deletions.
diff --git a/app/(dashboard)/search/page.tsx b/app/(dashboard)/search/page.tsx
@@ -6,7 +6,7 @@ import searchItemsByName from '@/supabase/models/searchItemsByName';
 import selectItemsByCreatedAt from '@/supabase/models/selectingItems/selectItemsByCreatedAt';
 import { SearchParamsType } from '@/types/searchPageTypes';
 import { PartialItem } from '@/types/supabaseTypes';
-import { useCallback, useEffect, useState } from 'react';
+import { useEffect, useState } from 'react';
 
 const initialSearchParams = {
   query: '',
@@ -21,7 +21,7 @@ export default function SearchItemPage() {
     useState<SearchParamsType>(initialSearchParams);
   const [searchResults, setSearchResults] = useState<PartialItem[]>([]);
 
-  const fetchSearchResults = useCallback(async () => {
+  const fetchSearchResults = async () => {
     let data: PartialItem[] = [];
     switch (true) {
       // case !!searchParams.query &&
@@ -58,7 +58,7 @@ export default function SearchItemPage() {
         break;
     }
     setSearchResults(data);
-  }, [searchParams]);
+  };
 
   useEffect(() => {
     fetchSearchResults();

diff --git a/components/search/ItemDisplayContainer.tsx b/components/search/ItemDisplayContainer.tsx
@@ -26,22 +26,18 @@ const ItemDisplayContainer: React.FC<ItemDisplayContainerProps> = ({
         </span>
       </h2>
       <div className='mt-10 flex flex-col items-center gap-5'>
-        {searchResults.length > 0 ? (
-          searchResults.map((result) => (
-            <ItemCard
-              key={result.id}
-              imageSrc={result.imageSrc}
-              item_name={result.item_name}
-              condition={result.condition}
-              item_type={result.item_type}
-              postcode={result.postcode}
-              postable={result.postable}
-              itemId={result.id}
-            />
-          ))
-        ) : (
-          <p className='text-center'>No results found.</p>
-        )}
+        {searchResults.map((result) => (
+          <ItemCard
+            key={result.id}
+            imageSrc={result.imageSrc}
+            item_name={result.item_name}
+            condition={result.condition}
+            item_type={result.item_type}
+            postcode={result.postcode}
+            postable={result.postable}
+            itemId={result.id}
+          />
+        ))}
       </div>
     </div>
   );

diff --git a/supabase/models/selectingItems/selectItemsByCreatedAt.ts b/supabase/models/selectingItems/selectItemsByCreatedAt.ts
@@ -12,7 +12,7 @@ const selectItemsByCreatedAt = async (
     let query = supabase
       .from('items')
       .select('*')
-      .order('created_at', { ascending: false })
+      .order('created_at')
       .limit(Number(limit));
 
     if (cursor) {