#190/show required fields lables on add item page by default

[AlexVOiceover]

Description

Closes #190
The add item form now shows correctly the fields that need to be filled even when an image wasn't attached yet. The previous behaviour was forcing the user to have an image uploaded.

Files changed

app/(dashboard)/add-item/page.tsx
Makes the comprobation of the image being uploaded

components/form/UploadImageInput.tsx
Will pass as a prop a flag to specify if the image was uploaded (onImageUpload)

app/(dashboard)/add-item/pageTypes.ts
This file was created to extend the type PartialItem to include the boolean 'imageUploaded'

UI changes

Tests

Manual tested. Try to create item without image and without some required fields

[netlify]

👷 Deploy request for cool-creponne-3e1272 pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	7e40e6b

[github-actions]

🤖 meep morp! This PR is now marked as stale because there has been no activity for a while. Please guarantee this is still a relevant PR.

[github-actions]

🤖 meep morp! This PR is now marked as stale because there has been no activity for a while. Please guarantee this is still a relevant PR.

[nichgalzin]

Hey @AlexVOiceover,
Can you please resolve the issues on on PR with the example .env file. Please and thanks. Then we can merge this PR.

[AlexVOiceover]

Hi @nichgalzin and team,

I have resolved the conflicts by merging the latest changes from the dev branch into my feature branch and deleting the .env.example file as per the upstream changes. The PR should now be ready for merging.

Thank you!

[camelPhonso]

Thanks for the update Alex.

Asked to remove an unnecessary file here.

[camelPhonso]

We no longer use Playwright on the code base so I presume this is an old report that got staged. Can you remove this from the PR please?

[AlexVOiceover]

The comprobation of the mandatory fields on the form and the presence of the image cannot be done in separate react components, that way it will only perform the "outer" component once that the nested one was resolved.
All comprobations were moved to the parent (AddNewItemForm.tsx).
For a similar reason it was needed to add the function handleFormSubmit as some kind of middleware. It will update isSubmitAttempted before trying to submit, so all the form mandatory fields comprobations and the error messages for the checkboxes and the image will be done at once.
Without this function, submitHandler will check the mandatory fields, and only after everything is right will carry on with checking the image.

setError and isRequired were left on the props for compatibility with other potential components that use this functionality, these should be udpated.

[camelPhonso]

Closing this PR as the issue has been handed over to another contributor