#190/show required fields lables on add item page by default #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass onImageUploaded instead relates enBloc-org#190
👷 Deploy request for cool-creponne-3e1272 pending review.Visit the deploys page to approve it
|
eliazzo
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
camelPhonso
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
camelPhonso
reviewed
May 22, 2024
eliazzo
reviewed
May 22, 2024
eliazzo
reviewed
May 24, 2024
|
🤖 meep morp! This PR is now marked as stale because there has been no activity for a while. Please guarantee this is still a relevant PR. |
github-actions
bot
added
the
Stale
Removed comment. Thanks Co-authored-by: eliazzo <114364165+eliazzo@users.noreply.github.com>
github-actions
bot
removed
the
Stale
|
🤖 meep morp! This PR is now marked as stale because there has been no activity for a while. Please guarantee this is still a relevant PR. |
github-actions
bot
added
the
Stale
camelPhonso
reviewed
Jul 5, 2024
camelPhonso
reviewed
Jul 5, 2024
nichgalzin
previously approved these changes
Jul 5, 2024
|
Hey @AlexVOiceover, |
|
Hi @nichgalzin and team, I have resolved the conflicts by merging the latest changes from the Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #190
The add item form now shows correctly the fields that need to be filled even when an image wasn't attached yet. The previous behaviour was forcing the user to have an image uploaded.
Files changed
app/(dashboard)/add-item/page.tsx
Makes the comprobation of the image being uploaded
components/form/UploadImageInput.tsx
Will pass as a prop a flag to specify if the image was uploaded (onImageUpload)
app/(dashboard)/add-item/pageTypes.ts
This file was created to extend the type PartialItem to include the boolean 'imageUploaded'
UI changes
Tests
Manual tested. Try to create item without image and without some required fields