#124/auto conversation restart

[eliazzo]

Description

Closes #124

If a user deletes the conversation and their partner continues to send messages the conversation is restarted for the user and displays all previous messages.

Files changed

components/messaging/ConversationsList.tsx

• payload is modified to mark member_has_deleted as true within the conversations object of the payload
• handler checks if the updated conversation is part of allConversations. If found, and if member_has_deleted is marked as true in the updated payload, it updates this value in the corresponding conversation in the state

components/messaging/MessageForm.tsx

• check if member_has_deleted is true, which means a conversation member had previously marked the conversation as deleted
• if the conversation has been marked as deleted, the convoRestart function is called
• After restarting the conversation, the state update for the currentConversation is performed to reset the member_has_deleted flag to false

supabase/models/messaging/convoRestart.ts

• convoRestart function reactivates the conversation in supabase after it has been marked as deleted

UI changes

no ui changes other than those merged from dev

[netlify]

✅ Deploy Preview for cool-creponne-3e1272 ready!

Name	Link
🔨 Latest commit	b831848
🔍 Latest deploy log	https://app.netlify.com/sites/cool-creponne-3e1272/deploys/66475a8a3e649000091bf35d
😎 Deploy Preview	https://deploy-preview-204--cool-creponne-3e1272.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[camelPhonso]

I've made some comments on naming conventions and cleaning up some comments, logs, ghost code..

BUT

while testing this I ran into a weird fringe case:

• create a conversation
• delete it on one end before sending any messages
• send a new message from the other side
• you've now got that message on screen twice (for the sender only)

This is quite edge and I think it could be a solve it with the feature live situation but maybe we should stress test the whole thing a little more before merging - maybe you should think about linking up one of the QA's to this ❓

[eliazzo]

I've made some comments on naming conventions and cleaning up some comments, logs, ghost code..

BUT

while testing this I ran into a weird fringe case:

• create a conversation
• delete it on one end before sending any messages
• send a new message from the other side
• you've now got that message on screen twice (for the sender only)

This is _quite_ edge and I think it could be a _solve it with the feature live_ situation but maybe we should stress test the whole thing a little more before merging - maybe you should think about linking up one of the QA's to this ❓

Thanks for this. Noting down our conversation from earlier here so we have a record:

This edge case should be solved once we correct the conversation start functionality. At the moment, when a user starts a conversation, the item owner is notified and has an empty conversation appear in their conversation list. The desired functionality is for the item owner to be notified only once the first message has been sent. This means that it will be impossible to create a conversation and send a message from the other side before a message has been sent and therefore this edge case cannot be recreated.