Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#208/review documentation for windows #211

Merged

Conversation

nataliiazab
Copy link
Collaborator

Description

**Relates #208
This is to add commands for Windows users when setting up a local database BEFORE_YOUR_FIRST_ISSUE.md.

The following commands were added:

npm install supabase --save-dev

npx supabase login

npx supabase start

The commands were successfully tested on my and @YuraPetrovskyi's machines 👌

Files changed

I've only updated the BEFORE_YOUR_FIRST_ISSUE.md file. However, after installing the Supabase CLI on my machine, my package.json was updated as below:
image

🙋The question I have: should I also commit changes for package.json and package-lock.json files? I haven't done it in this PR. Thanks 😊

Copy link

netlify bot commented May 17, 2024

👷 Deploy request for cool-creponne-3e1272 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3838de9

@camelPhonso
Copy link
Contributor

🙋The question I have: should I also commit changes for package.json and package-lock.json files? I haven't done it in this PR. Thanks 😊

Thanks for raising this @nataliiazab - I think you made the right call. Supabase should just be added to dev-dependencies since everyone will need it so I think this was not the best planning on our end. We'll just have that changed in it's own issue.

Copy link
Contributor

@camelPhonso camelPhonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and bringing Yurii in to double check 👌

This looks great! I'm just requesting a fix on a couple of lines where the markdown won't get rendered properly at the moment. I've highlighted one of the examples in the comments. Other than that, it's perfect :)

.github/BEFORE_YOUR_FIRST_ISSUE.md Outdated Show resolved Hide resolved
@nataliiazab
Copy link
Collaborator Author

Thanks for spotting this, @camelPhonso. I've fixed as suggested :)

Copy link
Contributor

@camelPhonso camelPhonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this 👍

@camelPhonso camelPhonso merged commit 1228feb into enBloc-org:dev May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants