Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#73/conversation container #212

Merged
merged 11 commits into from
May 23, 2024
Merged

#73/conversation container #212

merged 11 commits into from
May 23, 2024

Conversation

nichgalzin
Copy link
Contributor

@nichgalzin nichgalzin commented May 17, 2024

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review on my code
  • I have made corresponding changes to the documentation (if any were needed)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and previously existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Description

**Closes #73 **

  • This PR Fixes the displayed view when the individual view is displayed on mobile screen and attempts to begin fixing styling issue on devices of different sizes:

Files changed

app/(dashboard)/conversations/page.tsx - moves context to the layout for the dashboard route.
components/Footer.tsx - hides mobile navbar in message view
components/Header.tsx - updates content based on view and route
components/filter/BooksSubcategory.tsx - type fix
components/filter/QuickBrowse.tsx- typo fix
components/icons/BackArrowIcon.tsx - new reusable component
components/layout/FullHeightComponent.tsx - Layout component to dynamically calculation the height of parent
components.
components/messaging/ConversationWrapper.tsx - back button moved to header
components/messaging/CurrentConversation.tsx - conversation partner moved to header
context/Providers.tsx - new wrapper client component to hold context providers

Include one to two lines on the necessary changes to each file.

UI changes

Screenshot 2024-05-21 at 14 39 00

Copy link

netlify bot commented May 17, 2024

Deploy Preview for cool-creponne-3e1272 ready!

Name Link
🔨 Latest commit 8bc4d85
🔍 Latest deploy log https://app.netlify.com/sites/cool-creponne-3e1272/deploys/664f077fdc24bd0008c9417c
😎 Deploy Preview https://deploy-preview-212--cool-creponne-3e1272.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nichgalzin nichgalzin marked this pull request as ready for review May 22, 2024 10:14
camelPhonso
camelPhonso previously approved these changes May 22, 2024
Copy link
Contributor

@camelPhonso camelPhonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some Inline Commit Suggestions because comments are not code and (mostly) because I wanted to try that new trick - but apart from those I'm happy for this to get shipped ⛵

Thank you for the detailed comments on your PR 🖤

components/Header.tsx Show resolved Hide resolved
components/layout/FullHeightComponent.tsx Outdated Show resolved Hide resolved
components/Header.tsx Show resolved Hide resolved
Co-authored-by: Alphonso <114600712+camelPhonso@users.noreply.github.com>
@nichgalzin nichgalzin merged commit ed4f5cf into dev May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix viewport height to account for nav and footer 🍌
2 participants