#292 Improved mobile styling and item card layouts #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cool-creponne-3e1272 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camelPhonso
requested changes
Aug 9, 2024
There was a problem hiding this comment.
This is looking great!
I didn't really annotate any particular lines but one thing that came up is that the reserved label is showing only when we look at an item in our profile page (so in DonatedItemsList.tsx but not on the search page.
We also have a ternary in the image src attribute for ItemCard that won't really do anything because we have enforced the upload of an image when an item is added - that's some legacy code but worth cleaning up while we're at it.
…lay the reserved UI Relates #292
camelPhonso
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**Closes #292 **
This PR expands a bit on the issue and seeks to resolve a few layout issue with the app, specifically with the mobile experience. It seeks primarily to deal with stying issue on the search and about routes.
UI changes
Tests
Story files updated to reflect new information being displayed as well as show postage covered state.