CI tool: Remove hardcoded version #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
reviewed
Feb 16, 2021
tox.ini
Outdated
| @@ -65,7 +65,7 @@ commands = | |||
| yarn | |||
| make dist | |||
| # Test whl installation | |||
| pip install {toxinidir}/dist/kolibri_explore_plugin-0.0.1-py2.py3-none-any.whl | |||
| pip install {toxinidir}/dist/kolibri_explore_plugin-*.whl | |||
There was a problem hiding this comment.
This is not working, I think it's because the tox tooling that sees that like a filename and doesn't apply the glob. Maybe we should add the version here like a variable
There was a problem hiding this comment.
Yeah. I don't know about tox but I will check how to do that.
There was a problem hiding this comment.
Maybe this is interesting: tox-dev/tox#1571
There was a problem hiding this comment.
If it's too complex we can just remove this line from tests, it's something not required to test. With the make dist is enough.
There was a problem hiding this comment.
Indeed. I updated the PR disabling the command and referencing the ticket in tox.
From the github-actions configuration. We are disabling this command for now, since tox.ini doesn't support expanding globs. tox-dev/tox#1571 https://phabricator.endlessm.com/T31414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the github-actions configuration.
https://phabricator.endlessm.com/T31414