Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API descriptor can be optional #10673 #10674

Merged
merged 3 commits into from
Sep 5, 2024
Merged

API descriptor can be optional #10673 #10674

merged 3 commits into from
Sep 5, 2024

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (118608c) to head (236c6c3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...enonic/xp/portal/impl/handler/SlashApiHandler.java 81.25% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10674      +/-   ##
============================================
- Coverage     84.51%   84.51%   -0.01%     
+ Complexity    19906    19904       -2     
============================================
  Files          2627     2627              
  Lines         69118    69119       +1     
  Branches       5571     5570       -1     
============================================
  Hits          58413    58413              
  Misses         8020     8020              
- Partials       2685     2686       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from issue-10625-v2 to master September 5, 2024 07:57
@anatol-sialitski anatol-sialitski merged commit 1dc67bd into master Sep 5, 2024
8 of 9 checks passed
@anatol-sialitski anatol-sialitski deleted the issue-10673 branch September 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API descriptor can be optional
2 participants