Implement widgetUrl in admin lib #10697
#10698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatol-sialitski
force-pushed
the
issue-10697
branch
from
9627cb0
to
6e47543
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10698 +/- ##
=========================================
Coverage 84.55% 84.55%
Complexity 19958 19958
=========================================
Files 2633 2633
Lines 69255 69255
Branches 5588 5588
=========================================
Hits 58561 58561
Misses 8000 8000
Partials 2694 2694 ☔ View full report in Codecov by Sentry. |
rymsha
approved these changes
Sep 23, 2024
|
|
||
| return portal.apiUrl({ | ||
| application: 'admin', | ||
| api: `widget/${params.application}/${params.widget}`, |
There was a problem hiding this comment.
Suggested change
| api: `widget/${params.application}/${params.widget}`, | |
| api: `widget`, | |
| path: [${params.application}, ${params.widget}] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.