Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released Python 3.9 instead of prerelease #1303

Merged
merged 5 commits into from
Oct 12, 2020

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Oct 12, 2020

Python 3.9 has been released, so we should update the GitHub Actions continuous integration to run on 3.9 proper instead of on a pre-release version.

This PR updates the GitHub Actions test script accordingly.

xref: actions/setup-python#148

We should also update the Travis and Appveyor scripts, but I'm having difficulty finding evidence that the systems support Python 3.9 yet. I'll give it a try once the GitHub Actions change has completed.


EDIT: Updated to also drop Python 3.5 support for both Appveyor and Travis CI.

@mdickinson
Copy link
Member Author

For Appveyor, looks like we don't have 3.9 yet: appveyor/ci#3541. I suspect that's also true for Travis. I'll open an issue to remind us to update those eventually.

@mdickinson
Copy link
Member Author

Updated to drop Python 3.5 runs and add Python 3.8 runs for Appveyor, partially addressing #1304.

@mdickinson
Copy link
Member Author

There still seem to be issues with PySide 2 on Windows (both 32-bit and 64-bit). Here's the error for the 64-bit run (the error for the 32-bit run is almost identical).

PySide2/__init__.py: Unable to import shiboken2 from C:\projects\traits\testdir, C:\Python38-x64\python38.zip, C:\Python38-x64\DLLs, C:\Python38-x64\lib, C:\Python38-x64, C:\Python38-x64\lib\site-packages

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Contributor

Can you please update the description to mention that 3.5 was dropped from CI before merging?

@mdickinson
Copy link
Member Author

Can you please update the description to mention that 3.5 was dropped from CI before merging?

Done.

Before merging, I'm just going to quickly try replacing 3.9-dev with 3.9 for Travis. It probably won't work, but I can't find any information online about 3.9 support for Travis CI, and this seems like the quickest way to find out whether it's supported.

@mdickinson
Copy link
Member Author

Failed as expected:

Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/16.04/x86_64/python-3.9.tar.bz2
0.09s$ curl -sSf --retry 5 -o python-3.9.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
Unable to download 3.9 archive. The archive may not exist. Please consider a different version.

@mdickinson
Copy link
Member Author

mdickinson commented Oct 12, 2020

Random(?) failure on the Python 3.6 Linux Travis CI job:

Warning, treated as error:
failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.enthought.com/pyface/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
The command "pushd docs && python3 -m sphinx -b html -W source build && popd" exited with 2.

I'll restart that job.

@mdickinson mdickinson merged commit 8851f9c into master Oct 12, 2020
@mdickinson mdickinson deleted the build/update-to-3.9-release branch October 12, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants