This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
add get_nameserver_config to Lumberg::Whm::Dns. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubemz
approved these changes
Jul 4, 2017
fabiokr
approved these changes
Jul 4, 2017
|
@Tei1988 can you bump the version to |
|
@Tei1988 then we can merge and release the new version. |
boone
approved these changes
Jul 4, 2017
lib/lumberg/whm/dns.rb
Outdated
| @@ -52,6 +52,15 @@ def get_zone_record(options = {}) | |||
| server.perform_request('getzonerecord', options) | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
can you remove this extra newline?
|
Thank you all for review. I corrected them. |
|
@Tei1988 Thanks for this PR! Version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that get_nameserver_config API is not implemented.
So, I implemented it.
Review please.