Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes routing bug with same route, different params #4

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Fixes routing bug with same route, different params #4

merged 2 commits into from
Apr 24, 2018

Commits on Apr 17, 2018

  1. Adds failing test to same route dif param bug 

    > The first one is thrown when transitioning between routes with the same name but different params (e.g. from /articles/1 to /articles/2). The error is:

mike-north#83
    @ryanlabouve
    ryanlabouve committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d227442 View commit details
    Browse the repository at this point in the history

  2. Moves service to fire on setupController 

    This fixes the bug:

> The first one is thrown when transitioning between routes with the same name but different params (e.g. from /articles/1 to /articles/2). The error is:

ref mike-north#83
    @ryanlabouve
    ryanlabouve committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    4428988 View commit details
    Browse the repository at this point in the history