Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow ups on gRPC<->JSON transcoder filter #1192

Closed
lizan opened this issue Jun 30, 2017 · 4 comments
Closed

Follow ups on gRPC<->JSON transcoder filter #1192

lizan opened this issue Jun 30, 2017 · 4 comments
Assignees
@lizan
Labels
tech debt

Comments

@lizan
Copy link
Member

lizan commented Jun 30, 2017

  • Test coverage 100%
  • Factor out building PathMatcher.
@lizan lizan mentioned this issue Jun 30, 2017
Merged
@mattklein123 mattklein123 added this to the 1.4.0 milestone Jun 30, 2017
@lizan lizan mentioned this issue Jul 7, 2017
Merged
@mattklein123
Copy link
Member

I think this is complete. Closing.

@mattklein123
Copy link
Member

@lizan I'm going to reopen this as I just checked and there is still missing coverage on a few error paths. Please cover them when you do more features on the filter.

@mattklein123 mattklein123 reopened this Jul 16, 2017
@lizan
Copy link
Member Author

lizan commented Jul 17, 2017

Yes there are a few TODOs there. Will working on it soon.

@mattklein123 mattklein123 modified the milestones: 1.4.0, 1.5.0 Aug 4, 2017
@mattklein123 mattklein123 removed this from the 1.5.0 milestone Nov 3, 2017
@mattklein123
Copy link
Member

Closing as stale and not worth tracking.

jpsim pushed a commit that referenced this issue Nov 28, 2022
@junr03 @jpsim
bridge: add register string accessor functionality plus expose on And…
e667343 
…roid (#1188)

Description: this PR adds the ability to register string accessors from the platform to the engine. This allows the core layer to access strings from the platform at runtime. Two highlights:

    Eventually this mechanism should be made generic to be able to access and set arbitrary types from the platform. This is very type-specific as a POC. #1192
    This PR only wires up Android's platform layer all the way. A subsequent PR will do the same for iOS.

Risk Level: low - new API
Testing: using the example app.
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@junr03 @jpsim
bridge: add register string accessor functionality plus expose on And…
d7c8415 
…roid (#1188)

Description: this PR adds the ability to register string accessors from the platform to the engine. This allows the core layer to access strings from the platform at runtime. Two highlights:

    Eventually this mechanism should be made generic to be able to access and set arbitrary types from the platform. This is very type-specific as a POC. #1192
    This PR only wires up Android's platform layer all the way. A subsequent PR will do the same for iOS.

Risk Level: low - new API
Testing: using the example app.
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizan lizan

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizan @mattklein123