Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process Control on Windows #13188

Closed
davinci26 opened this issue Sep 18, 2020 · 0 comments · Fixed by #14352
Closed

Process Control on Windows #13188

davinci26 opened this issue Sep 18, 2020 · 0 comments · Fixed by #14352
Labels
area/windows enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Milestone
windows-ga

Comments

@davinci26
Copy link
Member

davinci26 commented Sep 18, 2020 •
edited
Loading

Title: Process Control on Windows

Description:

Process control primitives are different on POSIX and Windows. We need to add support for the following:

  1. Envoy should handle termination signals by the OS
  2. Envoy should handle termination signals by the user
  3. Envoy should be able to run persistently on the background as a SCM process.

Relevant Links:

Any extra documentation required to understand the issue.

  1. SCM
  2. Porting Envoy to Windows; A Progress Report - Yechiel Kalmenson & William A. Rowe, Jr., Pivotal
  3. Control Handler

cc: @envoyproxy/windows-dev
@davinci26 davinci26 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage area/windows labels Sep 18, 2020
@yanavlasov yanavlasov added help wanted Needs help! and removed triage Issue requires triage labels Sep 22, 2020
@sunjayBhatia sunjayBhatia added this to the windows-beta milestone Oct 2, 2020
@davinci26 davinci26 mentioned this issue Nov 10, 2020
Merged
ggreenway pushed a commit that referenced this issue Dec 8, 2020
[Win32 Signals] Add term and ctrl-c signal handlers (#13954)
9e2df02 
Part 1 of #13188. Adds support for ctrl+c and ctrl+break for Envoy on Windows.

The implementation for this following:

* On platform_impl we register a CtrlHandler which runs on a separate thread.
* On signal_impl we register a read event reader.
Thread (1) and (2) communicate via a socket pair and the event is handled on Windows the same way as it is handled on POSIX

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26 davinci26 mentioned this issue Dec 9, 2020
Merged
2 tasks
@davinci26 davinci26 mentioned this issue Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/windows enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
windows-ga
Development

Successfully merging a pull request may close this issue.

[Windows] Onboard Envoy to SCM davinci26/envoy
3 participants
@sunjayBhatia @yanavlasov @davinci26