Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: links broken for items like http_filters/grpc_json_transcoder_filter #19017

Closed
kriswuollett opened this issue Nov 16, 2021 · 1 comment · Fixed by #19018
Closed

docs: links broken for items like http_filters/grpc_json_transcoder_filter #19017

kriswuollett opened this issue Nov 16, 2021 · 1 comment · Fixed by #19018
Labels
area/docs bug

Comments

@kriswuollett
Copy link
Contributor

Title: docs: links broken for items like http_filters/grpc_json_transcoder_filter

Description:

Links to documentation like that found in the Sample Envoy configuration for gRPC JSON transcoding use a link path that predates #8027. Following these links yield page not found. Also the web links no longer need to use the www prefix.
@kriswuollett kriswuollett added the triage Issue requires triage label Nov 16, 2021
kriswuollett added a commit to kriswuollett/envoy that referenced this issue Nov 16, 2021
@kriswuollett
docs: fix links for public docs
bb10e0a 
Previously doc paths were not updated within envoyproxy#8027. Resolves envoyproxy#19017.

Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
@kriswuollett kriswuollett mentioned this issue Nov 16, 2021
Merged
@rojkov rojkov added area/docs bug and removed triage Issue requires triage labels Nov 17, 2021
@ankatare
Copy link
Contributor

seems it is tc in #19101

phlax pushed a commit that referenced this issue Dec 17, 2021
@kriswuollett
docs: fix links for public docs (#19018)
0a73992 
Previously doc paths were not updated within #8027. Resolves #19017.

* doc: Update doc paths to use full public URLs

The www prefix is not used as it would be removed by a HTTP redirect.

Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
joshperry pushed a commit to joshperry/envoy that referenced this issue Feb 13, 2022
@kriswuollett
docs: fix links for public docs (envoyproxy#19018)
d4f1818 
Previously doc paths were not updated within envoyproxy#8027. Resolves envoyproxy#19017.

* doc: Update doc paths to use full public URLs

The www prefix is not used as it would be removed by a HTTP redirect.

Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix links for public docs kriswuollett/envoy
3 participants
@rojkov @ankatare @kriswuollett