Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: refactor conn_manager code to remove AdminImpl specific logic #8225

Closed
stevenzzzz opened this issue Sep 12, 2019 · 3 comments · Fixed by #8809
Closed

cleanup: refactor conn_manager code to remove AdminImpl specific logic #8225

stevenzzzz opened this issue Sep 12, 2019 · 3 comments · Fixed by #8809
Assignees
@stevenzzzz
Labels
no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.13.0

Comments

@stevenzzzz
Copy link
Contributor

Issue Template

Title: refactor conn_manager code to remove AdminImpl specific logic

Description:
See #7762 (review)
A reminder for myself.

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@stevenzzzz
Copy link
Contributor Author

/assign stevenzzzz

@mattklein123 mattklein123 added tech debt no stalebot Disables stalebot from closing an issue labels Sep 15, 2019
@mattklein123 mattklein123 added this to the 1.12.0 milestone Sep 15, 2019
@mattklein123
Copy link
Member

@stevenzzzz can we potentially land this before we cut 1.12.0 in the next 1-1.5 weeks? Thank you.

@stevenzzzz
Copy link
Contributor Author

Let me work on it. Sorry for the procrastination.

@mattklein123 mattklein123 modified the milestones: 1.12.0, 1.13.0 Oct 22, 2019
@stevenzzzz stevenzzzz mentioned this issue Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenzzzz stevenzzzz

Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

hcm: remove Server::Admin from conn_manager_impl. stevenzzzz/envoy
2 participants
@stevenzzzz @mattklein123