hcm: remove Server::Admin from conn_manager_impl. #8809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:Admin specific logic from conn_manager_impl Signed-off-by: Xin Zhuang <stevenzzz@google.com>
mattklein123
requested changes
Oct 30, 2019
| @@ -232,6 +232,12 @@ class ConnectionManagerConfig { | |||
| */ | |||
| virtual absl::optional<std::chrono::milliseconds> idleTimeout() const PURE; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: newline, also general format issues
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
Awesome, thanks. Please merge master again to fix format. /wait |
|
formatted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…:Admin specific logic from conn_manager_impl
add isRoutable interface in connection manager config, remove Server::Admin specific logic from conn_manager_impl
Signed-off-by: Xin Zhuang stevenzzz@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Remove Server::Admin specific logic from conn_manager_impl.
Risk Level: LOW
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Fixes: #8225