Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRDS: remove first and then add to avoid scope-key conflict in the case a new resource contains the same same key as a to-be-deleted resource. #9349

Closed
stevenzzzz opened this issue Dec 13, 2019 · 1 comment · Fixed by #9366
Closed

SRDS: remove first and then add to avoid scope-key conflict in the case a new resource contains the same same key as a to-be-deleted resource. #9349

stevenzzzz opened this issue Dec 13, 2019 · 1 comment · Fixed by #9366
Assignees
@stevenzzzz

Comments

@stevenzzzz
Copy link
Contributor

Bug Template

Title: Remove first then add when adding a scope which has the same key as a to-be-deleted scope.

Description:

A new scope may have the same scope key as a to-be-deleted existing scope, in which case we should not raise an scope key conflict error.

Repro steps:
push -1: { scope A: keyA }
push -2: { Scope B: keyA } (in StoW API, this means deletion of "Scope A").
now in the delta form onConfigUpdate, we will report conflict error as the new scopeB 's "keyA" conflicts with the existing scopeA's key.
@stevenzzzz
Copy link
Contributor Author

/assign stevenzzzz

@stevenzzzz stevenzzzz mentioned this issue Dec 17, 2019
Merged
htuch pushed a commit that referenced this issue Dec 18, 2019
@stevenzzzz @htuch
srds: remove to-de-removed scopes first and then apply additions to a…
58802ba 
…void scope key conflict. (#9366)

Remove scopes first then add scopes to avoid scope key conflict when a new scope has the same key as an existing scope

Risk Level: MID
Testing: unit test
Docs Changes:
Release Notes:
Fixes: #9349

Signed-off-by: Xin Zhuang <stevenzzz@google.com>
prakhag1 pushed a commit to prakhag1/envoy that referenced this issue Jan 3, 2020
@stevenzzzz @prakhag1
srds: remove to-de-removed scopes first and then apply additions to a…
937e13c 
…void scope key conflict. (envoyproxy#9366)

Remove scopes first then add scopes to avoid scope key conflict when a new scope has the same key as an existing scope

Risk Level: MID
Testing: unit test
Docs Changes:
Release Notes:
Fixes: envoyproxy#9349

Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenzzzz stevenzzzz

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@stevenzzzz