config: bump to envoy-api 422332b. #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated build targets and switched canary to a metadata field.
|
Rekicking Travis. There was a TSAN failure that seems surprising, can't repeat locally with |
mattklein123
reviewed
Jul 4, 2017
source/common/upstream/eds.cc
Outdated
| @@ -47,11 +47,13 @@ void EdsClusterImpl::onConfigUpdate(const ResourceVector& resources) { | |||
| const std::string& zone = locality_lb_endpoint.locality().zone(); | |||
|
|
|||
| for (const auto& lb_endpoint : locality_lb_endpoint.lb_endpoints()) { | |||
| const bool canary = | |||
| Config::Utility::metadataValue(lb_endpoint.metadata(), "envoy.lb", "canary").bool_value(); | |||
There was a problem hiding this comment.
Can we add "envoy.lb" and "canary" to some type of MetadataConstants class or something? We will be referencing well known metadata in various places in the code and it would be good to put the well known things in a central place.
|
The TSAN flake bites again. I'll dig into this. |
I think TSAN was triggering some non-deterministic behavior on conflicting EXPECT_CALLs.
|
Root cause of |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Jul 7, 2017
Needed as a workaround for protocolbuffers/protobuf#3322. I'm going to work on an upstream fix once I unblock current dependencies on the merge of envoyproxy#1202. This increases image size from 2.3GB to 2.9GB. While it might be possible to only rebuild protobuf/lightstep, it's significantly more complicated throwaway build hacking to get there.
htuch
added a commit
that referenced
this pull request
Jul 7, 2017
Needed as a workaround for protocolbuffers/protobuf#3322. I'm going to work on an upstream fix once I unblock current dependencies on the merge of #1202. This increases image size from 2.3GB to 2.9GB. While it might be possible to only rebuild protobuf/lightstep, it's significantly more complicated throwaway build hacking to get there.
|
@mattklein123 This should now pass CI, can I get an approval? Thanks. |
mattklein123
approved these changes
Jul 7, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Fix env vars in Makefile * run tsan in circle ci
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: iOS parallel to #1188 Risk Level: low Testing: example app. Pending test with assertion filter. Docs Changes: pending full API docs Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: iOS parallel to #1188 Risk Level: low Testing: example app. Pending test with assertion filter. Docs Changes: pending full API docs Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build targets and switched canary to a metadata field.