http3: adding upstream API hooks #14839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
lizan
reviewed
Jan 27, 2021
|
|
||
| // [#not-implemented-hide:] | ||
| message Http3ProtocolOptions { | ||
| Http2ProtocolOptions http2_protocol_options = 1; |
There was a problem hiding this comment.
How does this configuration address the difference between H2 and H3? From a quick glance at the current spec, there are differences around SETTINGS, WINDOW_UPDATE frames.
There was a problem hiding this comment.
I guess the options are
- using Http2ProtocolOptions, and config-validating that fields which don't make sense don't apply
- copying most of the fields out of Http2ProtocolOptions so we don' t have the fields which make sense
- splitting Http2ProtocolOptions so we have http2/http3/shared today
I think 3) is undesirable today, especially as http3 hasn't fully landed yet. If we agree it may be the end goal, I think 1 is the least churn, so what I think we should go with, but I'm not committed to it so if you see other ideas or have other pros/cons let me know
There was a problem hiding this comment.
Yeah agreed 1 is least churn, can we add some comment to address those fields?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
comments addressed - PTAL when you get a chance! |
lizan
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adding explicit (hard-configured, or downstream-initiated) HTTP/3. Getting Auto for UDP/TCP is going to take substantially more work. HTTP/3 config will be rejected initially to keep this PR simple as possible.
Risk Level: Low (unused, hidden)
Testing: new unit tests
Docs Changes: n/a
Release Notes: n/a
Part of #14829