Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: changing how http3 is built, doing early config validation. #15412

Closed

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Mar 10, 2021

@mattklein123 is this a useful step in #12829 or no? If not I can just move the test elsewhere rather than deal with all the build complexity TODOs

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

part of #14829

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@mattklein123 mattklein123 self-assigned this Mar 10, 2021
@mattklein123
Copy link
Member

@alyssawilk this is roughly what I had in mind, but TBH I haven't looked through it in detail. Here is how I would personally approach it:

  1. Search the code for any place source (not extensions) references QUIC/QUICHE extension code or well known names. I'm pretty sure there are some. Can we get rid of these easily?
  2. Can we easily do cross config validation for all the pieces?

If we can't easily do (1) and (2) with everything being an extension I would do exactly what you are starting to do in this PR, and we can fully rip out all the extension loading stuff which I think will make things much simpler. Also see my other PR around the GSO batch writer. Let's land that other PR and then we can figure out what to do in aggregate?

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk closed this Mar 11, 2021
@alyssawilk alyssawilk deleted the upstream_quic_fail_load branch August 18, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants