quic: adding upstream config #15537
Merged
quic: adding upstream config #15537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
requested changes
Mar 17, 2021
| @@ -24,6 +24,12 @@ message TcpProtocolOptions { | |||
| "envoy.api.v2.core.TcpProtocolOptions"; | |||
| } | |||
|
|
|||
| message QuicProtocolOptions { | |||
There was a problem hiding this comment.
Maybe doc/comment about how these are protocol options shared between both downstream and upstream?
include/envoy/upstream/upstream.h
Outdated
| /** | ||
| * @return const envoy::config::core::v3::Http3ProtocolOptions& for HTTP/3 connections | ||
| * created on behalf of this cluster. | ||
| * @see envoy::config::core::v3::Http3ProtocolOptions. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas I didn't end up moving all of the protocol options over, as the cluster has its own timeout params so most of the QuicProtocolOptions are listener-specific.
Commit Message: adding quic protocol config to quic upstream
Risk Level: n/a (quic only)
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
part of #14829