Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: turn up the last upstream tests! #16279

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

alyssawilk
Copy link
Contributor

Several tests @danzh2010 fixed, plus one final test bug.

Risk Level: n/a
Testing: yes!
Docs Changes: n/a
Release Notes: n/a
#14829 among others

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

Hmmm, windows failure looks real.

@envoyproxy/windows-dev we haven't solved the "have a repro environment for windows" issue yet have we? If not can I get a volunteer to get me trace logs?

2021-05-03T15:01:37.6886147Z [ RUN ] UpstreamProtocols/DownstreamProtocolIntegrationTest.VeryLargeRequestHeadersRejected/IPv6_HttpDownstream_Http3Upstream
2021-05-03T15:01:37.6888952Z test/integration/http_integration.cc(1192): error: Value of: response->complete()
2021-05-03T15:01:37.6890771Z Actual: false
2021-05-03T15:01:37.6892168Z Expected: true
2021-05-03T15:01:37.6893243Z Stack trace:
2021-05-03T15:01:37.6894294Z 00007FF75A2B3310: (unknown)
2021-05-03T15:01:37.6895392Z 00007FF75A296035: (unknown)
2021-05-03T15:01:37.6897754Z 00007FF75A295EE3: (unknown)
2021-05-03T15:01:37.6899022Z 00007FF75A297A70: (unknown)
2021-05-03T15:01:37.6900225Z 00007FF75A298937: (unknown)
2021-05-03T15:01:37.6904210Z ... Google Test internal frames ...
2021-05-03T15:01:37.6904900Z
2021-05-03T15:01:37.6906224Z unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.

@davinci26
Copy link
Member

I can volunteer

@alyssawilk
Copy link
Contributor Author

Awesome, thank you so much! :-)
your call if you want to patch now, or wait until it lands. IMO there's no hurry.

Copy link
Contributor

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alyssawilk alyssawilk merged commit 3e56842 into envoyproxy:main May 4, 2021
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 5, 2021
Risk Level: n/a
Testing: yes!
Docs Changes: n/a
Release Notes: n/a
envoyproxy#14829 among others

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
Risk Level: n/a
Testing: yes!
Docs Changes: n/a
Release Notes: n/a
envoyproxy#14829 among others

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
Risk Level: n/a
Testing: yes!
Docs Changes: n/a
Release Notes: n/a
envoyproxy#14829 among others

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
@alyssawilk alyssawilk deleted the h3_all branch August 18, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants