Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_proto_plugin: Remove debugging code #21969

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 30, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the tooling-api-plugin-files branch from 8c73f79 to 54a5af7 Compare July 1, 2022 05:47
@wrowe wrowe requested a review from lizan July 6, 2022 14:44
@wrowe wrowe self-assigned this Jul 6, 2022
@wrowe wrowe requested a review from htuch July 8, 2022 15:00
@wrowe
Copy link
Contributor

wrowe commented Jul 8, 2022

Requesting review from @htuch who introduced the code now gated by cprofile_enabled.

From the slack, further comments from phlax;

To give more context, these are FileDescriptorProtos ie files including source codek, atm they are created as outputs but not used anywhere (afaict)
Also bazel recently added FileDescriptorProtos to ProtoSets so where we do actually need the source, which is going through this code we can grab it.
Re cprofile_enabled - mho is just remove the code guarded by it as it would require use of an action_env var to get the var there and that is not documented anywhere

It sounds to me that these are redundant and this was early diagnostic logic that never got mopped up from #8309?

@htuch
Copy link
Member

htuch commented Jul 10, 2022

Yeah, we can drop the cprofile stuff I think. But the this PR is now only about this, so the title no longer makes sense?

@phlax
Copy link
Member Author

phlax commented Jul 11, 2022

Yeah, we can drop the cprofile stuff I think.

so iiuc just remove - ill add patch now...

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title api_proto_plugin: Default to not including the fileprotos api_proto_plugin: Remove debugging code Jul 11, 2022
@phlax
Copy link
Member Author

phlax commented Jul 11, 2022

title updated

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 07ecace into envoyproxy:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants