Fix flaky integration test #33604
Merged
Fix flaky integration test #33604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antoniovleonti <leonti@google.com>
yanavlasov
approved these changes
Apr 17, 2024
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Apr 17, 2024
Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Apr 17, 2024
Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 18, 2024
Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
Signed-off-by: antoniovleonti <leonti@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: fix flaky integration tests
Additional Description: The ext_authz timeout integration tests were calling
waitForExtAuthzRequestwhen it wasn't necessary. This, combined with a short timeout duration (10ms), led to very rare flakes where the request would timeout before the stream was established or before the grpc message was sent. The request would then get cancelled andwaitForExtAuthzRequestwould fail.This PR removes all side stream expectations from the timeout integration tests since they are unnecessary. The HTTP tests weren't not flaky, but out of principle I did the same to them.
Risk Level: none
Testing: test-only PR
Docs Changes: none
Release Notes: none
Platform Specific Features: none
Fixes #33510
[Optional Runtime guard:]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]