ext_proc: elide redundant copy in ext_proc filter factory callback #36015
CI (Envoy) / Envoy/macOS
succeeded
Sep 6, 2024 in 28m 50s
Envoy/macOS (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/macOS (pr/36015/main@45dd128)
Check started by
Request (pr/36015/main@45dd128)
@antoniovleonti 45dd128
#36015 merge
main@b89afa2
elide redundant copy in ext_proc filter factory callback
Commit Message: elide redundant copy in ext_proc filter factory callback
Additional Description: the shared ptr is not needed in the function that created it after creating the callback. Just move the shared ptr into the callback to avoid the reference count being incremented then immediately decremented.
Risk Level: low
Testing: -
Docs Changes: -
Release Notes: -
Platform Specific Features: -
Environment
Request variables
Key | Value |
---|---|
ref | f28fccc |
sha | 45dd128 |
pr | 36015 |
base-sha | b89afa2 |
actor | @antoniovleonti |
message | elide redundant copy in ext_proc filter factory callback... |
started | 1725655297.785169 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 32 |
patch | 0 |
dev | true |
Loading