wasm: remove redundant xds attributes #36619
Open
+14
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I152e259f3f8e5f69463a64fedce4181ce606824b Signed-off-by: Kuat Yessenov <kuat@google.com>
|
/coverage |
|
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/36619/coverage/index.html The coverage results are (re-)rendered each time the CI |
Change-Id: I729d48ded84ce3451c936cbe228eb3b0f2fc04d0 Signed-off-by: Kuat Yessenov <kuat@google.com>
|
/assign @mpwarres, based on CODEOWNER |
|
neither of @mpwarres,, based, on, CODEOWNER can be assigned to this issue. |
|
/assign @mpwarres based on CODEOWNER |
|
Side note: @kyessenov @alyssawilk looks like WSAM doesn't have maintainer sponsor currently given Lizan has left? https://github.com/envoyproxy/envoy/blob/main/CODEOWNERS#L106-L116 |
|
I'm willing to sponsor the improvements to Wasm, as previously discussed. |
tyxia
added a commit
that referenced
this pull request
Oct 16, 2024
Per discussion #36619 (comment) Signed-off-by: tyxia <tyxia@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I152e259f3f8e5f69463a64fedce4181ce606824b
Commit Message: Remove attributes that were marked as deprecated in ff991f3. This improves the alignment of
get_propertyABI with the generic attribute support in Envoy in CEL, for example, and simplifies the implementation.Additional Description:
Risk Level: low, experimental filter, advanced warning to stop using attributes was given
Testing: updated
Docs Changes: yes
Release Notes: yes