Remove use_fast_protobuf_hash runtime flag #36645
Merged
+12
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
alyssawilk
approved these changes
Oct 16, 2024
alyssawilk
reviewed
Oct 16, 2024
|
Ah, sorry - I wasn't sure if removing a flag merited a changelog since it's quite self-documenting (you get a warn-level log if you're setting a flag that doesn't exist any more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove use_fast_protobuf_hash runtime flag
Additional Description: Fixes #36613
Risk Level: Should be a no-op for anyone who didn't override the flag.
Testing: Same as before but without the branches that no longer exist.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a