Redis mirroring should work when default value is zero, not just greater than zero #8089
Commits on Aug 29, 2019
-
Redis mirroring should be >=, not > as otherwise it will not read run…
…time settings unless default is > 0 Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
Commits on Sep 10, 2019
-
Merge branch 'master' into fix-mirror-percent
Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
-
Merge branch 'master' into fix-mirror-percent
Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
Commits on Sep 11, 2019
-
Check if default value for mirroring is set, and test zero case does …
…not mirror traffic Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
-
use has_runtime_fraction_ instead of has_default_value_
Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
-
use ternary operator with nullopt as fallback
Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.