Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct test of OptionsImpl argc type (Was: Correct type for std::array size() result) #9290

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Correct test of OptionsImpl argc type (Was: Correct type for std::array size() result) #9290

merged 3 commits into from
Dec 17, 2019

Commits on Dec 9, 2019

  1. Correct type for std::array size() result 

    The std::array API uses std::size_t for the size() nelts count.
This is a larger sized int than 'int', which causes this code
to break on Windows compilation.

Use the stdcxx type for conformance and portability.

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia
    sunjayBhatia authored and Garden Windows committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    a6882a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Add missing type changes to prior patch 

    Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe
    wrowe authored and Garden Windows committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    8fcb780 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Toggle the OptionsImpl argc from std::array to main() argc 

    - Reverts the prior proposal
- Overrides the std::array in tests to emulate argc/argv from main()

Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe
    wrowe committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    3310fd2 View commit details
    Browse the repository at this point in the history