Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: API boosting support for rewriting elaborated types. #9375

Merged
merged 5 commits into from
Dec 19, 2019
Merged

tools: API boosting support for rewriting elaborated types. #9375

merged 5 commits into from
Dec 19, 2019

Commits on Dec 17, 2019

  1. tools: API boosting support for rewriting elaborated types. 

    This PR introduces API boosting support for ElaboratedTypeLoc, one of a
number of Clang AST nodes that we need to analyze and rewrite to move to
the latest type according to the type database.

The approach taken is to generate a replacements YAML file suitable for
consumption by clang-apply-replacements; this is how clang-tidy works
internally. Replacements are a series of patch like file transformation
operations, Clang has nice support for building replacement sets and
serializing to YAML.

This PR also starts to split out api_booster into more modules (just
some utils to start with), introduces some more unit tests and a golden
C++ source file test framework.

Risk level: Low
Testing: New unit and e2e golden tests added.

Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    d3eb71c View commit details
    Browse the repository at this point in the history

  2. Cleanup only *.clang-replacements.yaml instead of *.yaml. 

    Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    72252cb View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Merge remote-tracking branch 'upstream/master' into api-type-upgrade

    @htuch
    htuch committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    e6a4ecd View commit details
    Browse the repository at this point in the history

  2. Some TODOs. 

    Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    d55e051 View commit details
    Browse the repository at this point in the history

  3. Review feedback. 

    Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    8994ecc View commit details
    Browse the repository at this point in the history