Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: upgrade Envoy source to v3alpha API. #9546

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

htuch
Copy link
Member

@htuch htuch commented Jan 3, 2020

This is the mega-upgrade patch taking Envoy from v2 to v3alpha internally. It consists of a mechanically generated upgrade patch ("Mechanical upgrade via api_boost.py.") and some post-upgrade manual fixups.

Risk level: Very high. It's possible that internal changes might manifest on the wire in unanticipated ways, e.g. via type URLs or config rejection.
Testing: All tests pass.

Fixes #8082

@htuch htuch changed the title all: update Envoy to v3alpha all: upgrade Envoy source to v3alpha API. Jan 3, 2020
@htuch htuch added the api/v3 Major version release @ end of Q3 2019 label Jan 3, 2020
@htuch htuch force-pushed the draft-e2e-4 branch 4 times, most recently from 9738709 to 3a66c1f Compare January 3, 2020 16:06
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Jan 5, 2020

@envoyproxy/api-shepherds this should be ready-to-merge once CI passes and we have LGTMs.

@mattklein123
Copy link
Member

(I didn't review this line by line but generally looks sane. Amazing work!. Let's merge and see what happens.)

@mattklein123 mattklein123 merged commit 21aa1a7 into envoyproxy:master Jan 6, 2020
@htuch htuch deleted the draft-e2e-4 branch January 6, 2020 03:50
sthagen added a commit to sthagen/envoyproxy-envoy that referenced this pull request Jan 6, 2020
all: upgrade Envoy source to v3alpha API. (envoyproxy#9546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 -> v3 API translation
3 participants