Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: refactor proto visitor pattern. #9807

Closed
wants to merge 1 commit into from
Closed

protobuf: refactor proto visitor pattern. #9807

wants to merge 1 commit into from

Commits on Jan 23, 2020

  1. protobuf: refactor proto visitor pattern. 

    Move the proto traversal handling in version_converter.cc to a
standalone library. This lets us replace existing proto visitor patterns in
common/protobuf/utility.cc for unexpected field checks.

The redaction code is actually a bit more involved, so I'm not
refactoring this; it needs to recurse through Any/TypedStruct.
Ultimately we might want something like this, but it doesn't seem super
helpful given we only have a the single instance of this right now.

Risk level: Low
Testing: Existing tests continue to pass.

Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    12fa78b View commit details
    Browse the repository at this point in the history