-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does Helm charts crds folder has Deployments? #1773
Comments
this's a known issue, plan to remove in v0.6. |
should be fixed with #1721 |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
should be fixed once we import upstream gateway api v1.0, which does not include any deployments or resources, relates to kubernetes-sigs/gateway-api#2401 |
Thanks. But my understanding is that further changes will be needed the envoy/gateway helm chart to install the webhook deployment. Is that correct? |
@tamalsaha webhook based validation has been replaced by CEL based validation which is baked into the CRD schema itself. |
Description:
https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/crds/gatewayapi-crds.yaml#L9195-L9440
As you can see helm crds folder has Deployment, and other types of resources. It should only have crds. What is going on here?
Repro steps:
Environment:
Logs:
The text was updated successfully, but these errors were encountered: