Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Helm charts crds folder has Deployments? #1773

Closed
tamalsaha opened this issue Aug 7, 2023 · 6 comments · Fixed by #1987
Closed

Why does Helm charts crds folder has Deployments? #1773

tamalsaha opened this issue Aug 7, 2023 · 6 comments · Fixed by #1987
Labels
area/installation kind/bug Something isn't working
Milestone

Comments

@tamalsaha
Copy link

Description:
https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/crds/gatewayapi-crds.yaml#L9195-L9440

As you can see helm crds folder has Deployment, and other types of resources. It should only have crds. What is going on here?

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

Logs:

Include the access logs and the Envoy logs.

@tamalsaha tamalsaha added the kind/bug Something isn't working label Aug 7, 2023
@zirain
Copy link
Contributor

zirain commented Aug 7, 2023

this's a known issue, plan to remove in v0.6.

@arkodg
Copy link
Contributor

arkodg commented Aug 7, 2023

should be fixed with #1721

@arkodg arkodg added this to the 0.6.0-rc1 milestone Aug 11, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Sep 11, 2023
@arkodg arkodg removed the stale label Oct 14, 2023
@arkodg
Copy link
Contributor

arkodg commented Oct 14, 2023

should be fixed once we import upstream gateway api v1.0, which does not include any deployments or resources, relates to kubernetes-sigs/gateway-api#2401

@tamalsaha
Copy link
Author

Thanks. But my understanding is that further changes will be needed the envoy/gateway helm chart to install the webhook deployment. Is that correct?

@arkodg
Copy link
Contributor

arkodg commented Oct 21, 2023

@tamalsaha webhook based validation has been replaced by CEL based validation which is baked into the CRD schema itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants