Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gateway api to v1.0.0-rc1 #1987

Merged
merged 10 commits into from
Oct 19, 2023
Merged

bump gateway api to v1.0.0-rc1 #1987

merged 10 commits into from
Oct 19, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 17, 2023 •
edited
Loading

  • update all YAML resources from v1beta1 to v1
  • update all go imports from v1beta1 to v1

Release details in https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.0.0-rc1

Since the new upstream YAML no longer add a webhook, admission controller this PR
Also fixes #1773

@arkodg arkodg requested a review from a team as a code owner October 17, 2023 20:46
@arkodg arkodg added release-note Indicates a required release note priority/high Label used to express the "high" priority level labels Oct 17, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #1987 (ef1c75c) into main (c8f358b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1987   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files          92       92           
  Lines       13509    13509           
=======================================
  Hits         8871     8871           
  Misses       4095     4095           
  Partials      543      543
Files Coverage Δ
internal/cmd/egctl/translate.go 83.12% <100.00%> (ø)
internal/envoygateway/config/config.go 84.61% <100.00%> (ø)
internal/gatewayapi/address.go 100.00% <100.00%> (ø)
internal/gatewayapi/clienttrafficpolicy.go 74.33% <ø> (ø)
internal/gatewayapi/envoypatchpolicy.go 78.66% <ø> (ø)
internal/gatewayapi/listener.go 97.79% <100.00%> (ø)
internal/gatewayapi/sort.go 100.00% <ø> (ø)
internal/gatewayapi/runner/runner.go 23.00% <0.00%> (ø)
internal/gatewayapi/contexts.go 84.30% <91.66%> (ø)
internal/gatewayapi/resource.go 67.27% <0.00%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

@arkodg arkodg marked this pull request as draft October 17, 2023 21:54
@zirain
Copy link
Contributor

zirain commented Oct 17, 2023

this will be part of v0.6?

@arkodg
Copy link
Contributor Author

arkodg commented Oct 17, 2023

@zirain yes

@arkodg arkodg marked this pull request as ready for review October 18, 2023 21:24
This was referenced Oct 18, 2023
Open
Closed
@arkodg arkodg requested review from a team, kflynn, zhaohuabing and Alice-Lilith and removed request for a team October 18, 2023 21:31
This was referenced Oct 18, 2023
Closed
Closed
zirain
zirain reviewed Oct 18, 2023
View reviewed changes
test/e2e/e2e_test.go
@@ -33,8 +33,8 @@ func TestE2E(t *testing.T) {
client, err := client.New(cfg, client.Options{})
require.NoError(t, err)

require.NoError(t, v1alpha2.AddToScheme(client.Scheme()))
require.NoError(t, v1beta1.AddToScheme(client.Scheme()))
require.NoError(t, gwapiv1a2.AddToScheme(client.Scheme()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why keep this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For TCPRoute, GRPCRoute, TLSRoute, UDPRoute

zirain
zirain previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this's something EG must do, thanks @arkodg for all the efforts.

@zirain
Copy link
Contributor

zirain commented Oct 18, 2023

@envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers PTAL.

@arkodg
bump gateway api to v1.0.0-rc1
de737b0 
* update all YAML resources from `v1beta1` to `v1`
* update all go imports from `v1beta1` to `v1`

Release details in https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.0.0-rc1

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
more fixes
582a026 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
fix doc tool
356d70c 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
run make generate to gen api docs
7e66767 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
run make testdata
2ba6bb4 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
rm gateway-system
6a05103 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
skip test
c1f4654 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
skip GatewayStaticAddresses
8ee8add 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
update experimental test suite
23bc0b3 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
fix refgrant group version in mc yaml
ef1c75c 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zhaohuabing
zhaohuabing approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @arkodg, for taking care of the chores.

@arkodg arkodg requested a review from zirain October 19, 2023 00:09
@arkodg arkodg enabled auto-merge (squash) October 19, 2023 00:41
@arkodg arkodg merged commit d3110e3 into envoyproxy:main Oct 19, 2023
21 checks passed
@arkodg arkodg deleted the gw-api-v1.0.0-rc1 branch October 19, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@zirain zirain zirain approved these changes

@kflynn kflynn Awaiting requested review from kflynn kflynn was automatically assigned from envoyproxy/gateway-reviewers

@Alice-Lilith Alice-Lilith Awaiting requested review from Alice-Lilith Alice-Lilith was automatically assigned from envoyproxy/gateway-reviewers

Assignees
No one assigned
Labels
priority/high Label used to express the "high" priority level release-note Indicates a required release note
Projects
None yet
Milestone
0.6.0-rc1
Development

Successfully merging this pull request may close these issues.

Why does Helm charts crds folder has Deployments?
3 participants
@arkodg @zirain @zhaohuabing