Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go build version to something current #532

Closed
jpeach opened this issue Dec 21, 2021 · 7 comments · Fixed by #536
Closed

Update go build version to something current #532

jpeach opened this issue Dec 21, 2021 · 7 comments · Fixed by #536

Comments

@jpeach
Copy link
Contributor

jpeach commented Dec 21, 2021

In #272, go.mod was downgraded to Go 1.11. While that was an unsupported release at the time, it's still unsupported. Per the Go release policy, the last 2 major releases are supported, which at time of writing puts us on 1.17 or 1.16.

The downgrade was done to support grpcurl, which I guess ended up taking a go-control-plane dependency via gRPC. grpcurl is on Go 1.15 now, so that seems like a safe minimum. My preference would still be to use oldest supported Go release.
@jpeach
Copy link
Contributor Author

jpeach commented Dec 21, 2021

ping @alecholmez @snowp @kyessenov

@jpeach
Copy link
Contributor Author

jpeach commented Dec 21, 2021

grprc-go depends on go-control-plane and Go 1.14, so it would be less disruptive to only bump up to 1.14.

@alecholmez
Copy link
Contributor

This works for me let's bump it up

@jpeach
Copy link
Contributor Author

jpeach commented Jan 3, 2022

Ping @markdroth for gRPC perspective.

IIUC, bumping the go-control-plane version pasts Go 1.14 (which is where gRPC is) would have no immediate ill effects. The risk would be that if go-control-plane starts to use > 1.14 language features, that would not build in a Go 1.14 program (and people using gRPC might get a nasty surprise).

@jpeach jpeach mentioned this issue Jan 4, 2022
Merged
jpeach added a commit to jpeach/go-control-plane that referenced this issue Jan 4, 2022
@jpeach
Update the Go version to 1.16.
d500303 
Update the Go version directive to 1.16 since that is currently the
oldest supported go release.

This fixes envoyproxy#532.

Signed-off-by: James Peach <jpeach@apache.org>
@markdroth
Copy link

@dfawley is the right person to weigh in on grpc-go issues.

@sunjayBhatia
Copy link
Member

grpc-go also mentions it should be used with any one of the three latest major releases. (link)

probably worth bumping up the module requirement there to ensure that statement is correct as well

alecholmez pushed a commit that referenced this issue Jan 4, 2022
@jpeach
Update the Go version to 1.16. (#536)
c047955 
Update the Go version directive to 1.16 since that is currently the
oldest supported go release.

This fixes #532.

Signed-off-by: James Peach <jpeach@apache.org>
@sunjayBhatia
Copy link
Member

sent grpc/grpc-go#5102 as well to start a discussion

@sunjayBhatia sunjayBhatia mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the Go version to 1.16. jpeach/go-control-plane
4 participants
@jpeach @alecholmez @sunjayBhatia @markdroth