Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sotw: [#558] Support dynamic wildcard subscription in sotw-xds #571

Closed

Conversation

valerian-roche
Copy link
Contributor

Akin to #559, this PR is adding support for the new envoy wildcard semantics in the context of the SOTW server
It is also doing significant work merging logic between the delta and sotw parts, especially for shared objects like StreamState where we currently have different members representing the same functional concern based on the server used

The PR is quite large mainly due to:

  • large nb of tests added or updated
  • merge of stream state semantics between sotw and delta, and no longer relying on request resources for wildcard status in sotw
  • merge of accessors on stream state required aligning map[string]bool and map[string]struct{}. An implementation choice here was to align on map[string]struct{} to not alter delta as much as possible, but the revert can be done

I can rework it in multiple smaller PRs to handle some parts independently (mostly aligning the maps) if preferred by reviewers

…ard mode

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
@alecholmez
Copy link
Contributor

alecholmez commented Jul 11, 2022

Ah this is awesome thanks @valerian-roche. I'll start the review process on this now. Would you mind resolving those merge conflicts?

@valerian-roche
Copy link
Contributor Author

Hey @alecholmez
I fixed the conflicts for the PR
As it's quite big, I can split it a bit more if you prefer

@alecholmez
Copy link
Contributor

alecholmez commented Aug 8, 2022

@fxposter given our conversations in slack I think this is now nullified if we don't want to track state in sotw. Can you review real quick and confirm?

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 7, 2022
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants