Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync/ci: Use new Envoy api.go target #707

Merged
merged 1 commit into from
Jun 3, 2023
Merged

sync/ci: Use new Envoy api.go target #707

merged 1 commit into from
Jun 3, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 1, 2023

No description provided.

@phlax phlax changed the title sync/ci: Use new Envoy api.go target [WIP/TESTING] sync/ci: Use new Envoy api.go target Jun 1, 2023
@phlax phlax marked this pull request as draft June 1, 2023 11:10
@phlax
sync/ci: Use new Envoy api.go target
ad89921 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Jun 1, 2023 •
edited
Loading

tested and working against my pr https://github.com/envoyproxy/go-control-plane/actions/runs/5143618262/jobs/9258858557?pr=707#step:5:152

needs to land simultaneously with after envoyproxy/envoy#27675

@phlax phlax changed the title [WIP/TESTING] sync/ci: Use new Envoy api.go target sync/ci: Use new Envoy api.go target Jun 1, 2023
@phlax phlax marked this pull request as ready for review June 1, 2023 11:18
@phlax phlax merged commit f1ec428 into envoyproxy:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecholmez alecholmez alecholmez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phlax @alecholmez