Document that well-known names are no longer needed. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
force-pushed
the
doc-wellknown-named
branch
from
fa7d410
to
251f2ba
Compare
sunjayBhatia
previously approved these changes
Aug 24, 2023
alecholmez
previously approved these changes
Aug 25, 2023
jpeach
force-pushed
the
doc-wellknown-named
branch
from
251f2ba
to
5474e04
Compare
Envoy hasn't needed well-known filter names for a long while. Document that fact so that this package stops confusing people. This fixes envoyproxy#756. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
doc-wellknown-named
branch
from
5474e04
to
a469115
Compare
|
I added the deprecated keyword to the docs, per suggestion from @antonincms. |
|
@alecholmez @sunjayBhatia Sorry, could you please re-approve? |
sunjayBhatia
approved these changes
Aug 29, 2023
jpeach
added a commit
to jpeach/go-control-plane
that referenced
this pull request
Sep 4, 2023
Since we deprecated wellknown names in envoyproxy#763, fix the lint warnings that resulted by removing our internal use of the package. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
added a commit
that referenced
this pull request
Sep 14, 2023
Since we deprecated wellknown names in #763, fix the lint warnings that resulted by removing our internal use of the package. Signed-off-by: James Peach <jpeach@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy hasn't needed well-known filter names for a long while. Document that fact so that this package stops confusing people.
This fixes #756.