Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the v2 protobuf module internally. #819

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Use the v2 protobuf module internally. #819

merged 2 commits into from
Nov 20, 2023

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Nov 19, 2023

There's only one place where we use the protobuf APIs, so switch to the v2 protobuf module.

This updates #524.

@jpeach
Use the v2 protobuf module internally.
ccadde9 
There's only one place where we use the protobuf APIs, so switch
to the v2 protobuf module.

This updates envoyproxy#524.

Signed-off-by: James Peach <jpeach@apache.org>
sunjayBhatia
sunjayBhatia approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all the other usages of github.com/golang/protobuf seem to be from the generated APIs

valerian-roche
valerian-roche approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@valerian-roche valerian-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as it changes a public interface we might want to reflect it in the version when releasing

@jpeach
Copy link
Contributor Author

jpeach commented Nov 20, 2023

LGTM, but as it changes a public interface we might want to reflect it in the version when releasing

Agreed. I'm going to look at moving the generated protos to V2 as well, so maybe we can cut a release after that?

@jpeach jpeach merged commit a47957f into envoyproxy:main Nov 20, 2023
3 checks passed
@jpeach jpeach deleted the use-protobuf-v2 branch November 20, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@valerian-roche valerian-roche valerian-roche approved these changes

@alecholmez alecholmez Awaiting requested review from alecholmez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpeach @sunjayBhatia @valerian-roche