Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/cncf/xds/go to v0.0.0-20240329184929 #931

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@mmorel-35
Copy link
Contributor Author

@phlax ,
Would you mind reviewing this ?

phlax
phlax previously approved these changes Apr 25, 2024
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@phlax
Copy link
Member

phlax commented Apr 25, 2024

fail, looks ~real

 + make -C xdsmatcher test
make: Entering directory '/go-control-plane/xdsmatcher'
go test ./... -race
go: errors parsing go.mod:
go.mod:26: replacement module without version must be directory path (rooted or starting with ./ or ../)
make: *** [Makefile:3: test] Error 1
make: Leaving directory '/go-control-plane/xdsmatcher'
make: *** [Makefile:95: docker_tests] Error 2

https://github.com/envoyproxy/go-control-plane/actions/runs/8837729638/job/24267224339?pr=931#step:3:2783

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@phlax phlax merged commit 3d9f45c into envoyproxy:main Apr 25, 2024
5 checks passed
@mmorel-35 mmorel-35 deleted the cncf-xds branch April 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants