-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go version to 1.21 #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor
cc @envoyproxy/go-control-plane
It might even be better to use 1.21 as grpc v1.65.0 is requiring it |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! This should enable work on splitting the generated API in its own module to resume
Can this be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
landing on the basis of prior approvals
lgtm, thanks @mmorel-35
I don't know what it the policy with golang version usage.
1.22 is out with several patches and 1.17 is not supported according to golang versioning policy