Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic config update via xDS Management Server #373

Merged
merged 24 commits into from
Feb 7, 2023
Merged

Dynamic config update via xDS Management Server #373

merged 24 commits into from
Feb 7, 2023

Conversation

renuka-fernando
Copy link
Contributor

@renuka-fernando renuka-fernando commented Oct 25, 2022 •
edited
Loading

Description

Fix #201

Design

Tasks

  • Unit Tests
  • Integration Tests
  • An example xDS server - within docker-compose-example setup
  • Doc update for configs

@renuka-fernando
Move runtime file watcher from server to file provider
c24b743 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Update unit tests of service
7aeb1e8 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add xDS config proto files
df1e1b4 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Move provider to a new package from config package
c87441c 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add config xDS client
dd9a703 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Remove runtime usage in service
9b3d09e 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add unit tests for xDS config provider
a3adcc9 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add integration tests for xDS config provider
a94b006 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add integration tests for xDS config reload
e1f0ece 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Enable TLS for xDS configuration client
6ad7ad8 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add sample xDS sever
2cf48fa 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Separate the logic that converts string format of config file to yaml
e9e2a9e 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Convert xDS proto to yaml and use yaml as the config instead of file …
2ba99f9 
…content string

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add RateLimitUnit enum in rate limit config xDS proto
943907a 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Add unit tests for test domain merge functionality
0955383 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Update docs for rate limit xDS config management service
be6c107 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando renuka-fernando mentioned this pull request Oct 25, 2022
Closed
@renuka-fernando
Using ADS client from GCP
b591364 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Correct the config name 'CONFIG_GRPC_XDS_SERVER_TLS_SAN'
192cd92 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando renuka-fernando mentioned this pull request Dec 6, 2022
Merged
@carnei-ro
Copy link

Having a controller to handle the RateLimit configurations would be really nice!

@renuka-fernando
Merge branch 'main' of https://github.com/envoyproxy/ratelimit into x…
912864c 
…ds-conf-provider-impl

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Conflicts:
	go.sum
	src/config/config_impl.go
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 12, 2023
@renuka-fernando
Merge branch 'main' of https://github.com/envoyproxy/ratelimit into x…
5b55133 
…ds-conf-provider-impl

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>

Conflicts:
	go.sum
@github-actions github-actions bot removed the stale label Jan 17, 2023
@renuka-fernando
Update go-control-plane version which contains ADS Client implementation
f8f0e4a 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Copy link
Contributor Author

Hi @mattklein123,

ADS Client implementation is merged envoyproxy/go-control-plane#604 and updated the go-control-plane version to reflect the client implementation. Could you please review this PR?

Thanks.

@renuka-fernando
Update go-control-plane version which contains rate limit impl in sample
6ea0628 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@mattklein123 mattklein123 self-assigned this Feb 6, 2023
mattklein123
mattklein123 requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I skimmed and in general LGTM. Fine to ship and iterate with the small nit fix, thanks.

examples/xds-sotw-config-server/logger.go Outdated Show resolved Hide resolved
@renuka-fernando
Remove license headers
1873901 
envoyproxy#373 (comment)
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando
Include rate limit config xDS proto
4f54625 
Related to envoyproxy#371

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
mattklein123
mattklein123 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 1a68686 into envoyproxy:main Feb 7, 2023
@collinlee
Copy link

@alecholmez - is there a resource somewhere that shows how to use the dynamic config updates via xDS to update envoy ratelimit configuration?

@renuka-fernando
Copy link
Contributor Author

@alecholmez - is there a resource somewhere that shows how to use the dynamic config updates via xDS to update envoy ratelimit configuration?

Here is an example xDS server that will update the configuration of the rate limit service https://github.com/envoyproxy/ratelimit/tree/main/examples/xds-sotw-config-server.

If you want to configure envoy, refer to this doc https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/global_rate_limiting.
Route configuration: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-virtualhost-rate-limits.

@collinlee
Copy link

Thank you!

@zirain zirain mentioned this pull request Apr 4, 2023
Closed
barroca pushed a commit to barroca/ratelimit that referenced this pull request Sep 1, 2023
@renuka-fernando @barroca
Dynamic config update via xDS Management Server (envoyproxy#373)
9457f59 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@akondapuram akondapuram mentioned this pull request Jan 5, 2024
Merged
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
@renuka-fernando @timcovar
Dynamic config update via xDS Management Server (envoyproxy#373)
17e0776 
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How can I use the ratelimit setting dynamically?
4 participants
@renuka-fernando @carnei-ro @collinlee @mattklein123