Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect xds-relay in e2e pathways #85

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

jessicayuen
Copy link
Member

@jessicayuen jessicayuen commented May 13, 2020

Sample e2e test run: https://github.com/envoyproxy/xds-relay/pull/85/checks?check_run_id=757388131

  • Also add debug logging everywhere. It's much more apparent what's
    happening now.

Signed-off-by: Jess Yuen jyuen@lyft.com

@jessicayuen
Copy link
Member Author

Progress on this will be blocked until envoyproxy/go-control-plane#299 is addressed.

- Also add debug logging everywhere. It's much more apparent what's
  happening now.

Signed-off-by: Jess Yuen <jyuen@lyft.com>
@jessicayuen jessicayuen marked this pull request as ready for review June 10, 2020 09:13
Signed-off-by: Jess Yuen <jyuen@lyft.com>
@jessicayuen jessicayuen linked an issue Jun 10, 2020 that may be closed by this pull request
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing.

@jessicayuen jessicayuen merged commit c83a956 into envoyproxy:master Jun 11, 2020
LisaLudique pushed a commit to LisaLudique/xds-relay that referenced this pull request Jun 17, 2020
Sample e2e test run: https://github.com/envoyproxy/xds-relay/pull/85/checks?check_run_id=757388131

- Also add debug logging everywhere. It's much more apparent what's
  happening now.

Signed-off-by: Jess Yuen <jyuen@lyft.com>
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hook up envoy to xds-relay instance in e2e test
2 participants