[docs] Ensure react-addons-test-utils is set to react-dom
#1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure how a documentation change failed the build. Will try to reproduce locally. EDIT: Looks like Would appreciate a rebuild or pass. |
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 12, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
juanca
changed the title
react-addons-test-utils is set to react-domreact-addons-test-utils is set to react-dom
|
@juanca thanks, reran it. would you mind rebasing on the command line however, so there's no merge commits? |
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 14, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
As per this issue #940 (comment)
Follow suggestion per #940 (comment)
|
Done and done. Lemme know if y'all need any more changes. |
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 14, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
ljharb
approved these changes
Jul 15, 2017
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 17, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 24, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 25, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Jul 27, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
naganowl
added a commit
to naganowl/enzyme
that referenced
this pull request
Aug 9, 2017
Follows the suggestion enzymejs#940 (comment) and complements enzymejs#1030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps related issues:
react-addons-test-utilswhen it is not needed #968