➿ Deduplicate compilation modes (#244)

eomii · May 28, 2024 · 2fce774 · 2fce774
1 parent fe19e4e
commit 2fce774
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/ll/attributes.bzl b/ll/attributes.bzl
@@ -8,6 +8,7 @@ load("//ll:llvm_project_deps.bzl", "LLVM_PROJECT_DEPS")
 load("//ll:providers.bzl", "LlInfo")
 load(
     "//ll:transitions.bzl",
+    "COMPILATION_MODES",
     "transition_to_bootstrap",
     "transition_to_cpp",
 )
@@ -31,14 +32,7 @@ DEFAULT_ATTRS = {
         the `ll_toolchain`.
         """,
         default = "cpp",
-        # TODO: hip_amd, sycl_amd
-        values = [
-            "cpp",
-            "cuda_nvptx",
-            "hip_amdgpu",
-            "hip_nvptx",
-            "bootstrap",
-        ],
+        values = COMPILATION_MODES,
     ),
     "compile_flags": attr.string_list(
         doc = """Flags for the compiler.

diff --git a/ll/transitions.bzl b/ll/transitions.bzl
@@ -3,6 +3,7 @@
 Transitions used by the `ll_toolchain` rule.
 """
 
+# TODO: hip_amd, sycl_amd
 COMPILATION_MODES = [
     "bootstrap",
     "cpp",