🚩 Lift flags to configurations #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we passed Nix-specific configuration globally to Bazel's `action_env`. This caused every change in the Nix configs to invalidate the entire build graph. The new setup no longer influences any `rules_cc` invocations and selectively injects flags only into the transitioned `ll_toolchains` when they're actually needed. This maximizes the potential for cache reuse after changing the nix configuration and is overall a more modular and idiomatic approach. The new flags may be manually overridden via e.g. `--@rules_ll//ll:LL_CFLAGS=x:y:z`. This change also introduces `*_string_flags` attributes for `ll_*` rules which may be used to pass in Bazel-Skylib's `string_flag` targets to `ll_*` targets. These new flags follow the common pattern of supporting multiple arguments, separated by colons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we passed Nix-specific configuration globally to Bazel's
action_env. This caused every change in the Nix configs to invalidate the entire build graph.The new setup no longer influences any
rules_ccinvocations and selectively injects flags only into the transitionedll_toolchainswhen they're actually needed. This maximizes the potential for cache reuse after changing the nix configuration and is overall a more modular and idiomatic approach.The new flags may be manually overridden via e.g.
--@rules_ll//ll:LL_CFLAGS=x:y:z.This change also introduces
*_string_flagsattributes forll_*rules which may be used to pass in Bazel-Skylib'sstring_flagtargets toll_*targets. These new flags follow the common pattern of supporting multiple arguments, separated by colons.